Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grouping): collapse all then expand sub-group, fixes #512 #516

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

ghiscoding
Copy link
Collaborator

@ghiscoding ghiscoding commented Jun 29, 2020

kp6b6pFO1r

- it seems that previous PR #487 brought a new regression bug, the fix is to simply pass the level to the addTotals function
@ghiscoding
Copy link
Collaborator Author

@6pac are you going to be ok to release a new version after this?
It's starting to be time on my side to get this new version if possible
Thanks

@6pac
Copy link
Owner

6pac commented Jun 29, 2020

OK, thanks for looking into that. I had a quick look and decided I needed to investigate further, but you have done that. I've had unexpected EOFY work crop up, so back to being busy :-(
Don't think I'll get to the Async Render stuff, I'll just release with this fix if that works for you.

@6pac 6pac merged commit fc2dfd7 into master Jun 29, 2020
@ghiscoding
Copy link
Collaborator Author

That would be great if possible thanks, I can help you later with the Async if you need help with that.

@ghiscoding ghiscoding deleted the bugfix/grouping-expand branch July 24, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group Expand broken after Collapse All
2 participants