fix(gridMenu): Grid Menu wrong location changing from regular to frozen #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a new SlickGrid event `onSetOptions` to know when users dynamically changes the grid from regular to frozen (or vice versa) - the issue was that when changing a grid dynamically from regular to a frozen grid, the Grid Menu is positioned at the wrong location (shows up on left container instead of right container), the reason is because a regular grid uses the Left Grid Pane, while a frozen grid uses both left/right Grid Pane and its menu should be on the right Grid Pane (instead of left for a regular grid).
ghiscoding
commented
Jun 11, 2020
This was referenced Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onSetOptionsto know when users dynamically changes the grid from regular to frozen (or vice versa)TODO
example-frozen-columns-and-column-group.htmlto test it)BEFORE FIX
you can see the grid menu showing up on the left container, on its top right, but it really shouldn't be there
AFTER FIX
grid menu is only on top right corner of the grid, where it should always be