Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(animation): add option to disable animation on all setVisibility fn #481

Merged
merged 1 commit into from
May 6, 2020

Conversation

ghiscoding
Copy link
Collaborator

@ghiscoding ghiscoding commented Apr 8, 2020

  • this PR allows to disable the built-in slide animation (which uses jQueryUI), I have a particular use case where I toggle the filter bar after the grid creation and I don't want to see the animation at all, it has to happen instantly without the user noticing the filter header row was ever open.

  • added a boolean flag as 2nd argument to each functions, the default is still the animation, so it won't change default behavior

  • manually tested with the Grid Menu Example with/without animation, see animated gif below

    • note the gif start with animation, then later reload the page and disable all animation with extra false argument

lBM1e6cqwa

@ghiscoding
Copy link
Collaborator Author

ghiscoding commented Apr 27, 2020

@6pac
Hello Ben, do you think you'll have a chance to review my 2 PRs in the coming couple weeks? Not a huge rush but I'd be happy to see them merge eventually :)

This one in particular touches slick.grid core, so you might want to review it. The other PR is for a plugin, which I guess I could have merged myself.

Cheers mate.

@6pac 6pac merged commit a35c643 into master May 6, 2020
@ghiscoding ghiscoding deleted the feat/remove-visibility-animations branch May 18, 2020 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants