-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugins): add ways to use all 3 plugins together, closes #347 #474
Conversation
- this PR allows to use 3 plugins (RowDetail, RowMoveManager & CheckboxSelector) all at the same time - in order to achieve that, I added 2 new options to the Row Move Manager Plugin, the new options are (singleRowMove & disableRowSelection) and their default are set to false so it doesn't break anyone's code
- simplify the creation and use of the row move column by adding a getColumnDefinition() similar to the Checkbox Selector plugin - previous code still work the same, using the getColumnDefinition() is totally optional
@6pac Since there are a lot of commits, I strongly suggest you use the green "Squash and merge" button when merging. Would you mind doing another release, I'd like to pull the changes through NPM, thanks again mate (take your time though, it can wait a few days or a week, no rush). |
@6pac |
It's all 100% automated and worked flawlessly until recently. It seems I'm getting write or permissions failures somewhere in the process. |
Perhaps you forgot to update your local code before running Ahh ok you automate that process, that is about the only thing I still do manually hehe |
hmmm. .. is it the new |
@6pac BTW, you can test it yourself too if you wish, just So I think the best is to repackage (or rebundle) it and do another release. |
@6pac I found this website Unpkg, it shows exactly what each version of an NPM bundle has, for example unpkg - slickgrid@2.4.21. This helped me find out that the error was completely on my side. |
no worries, I had just reached the same conclusion. When I |
closes Using Checkboxes with DetailView #347
this PR allows to use 3 plugins (RowDetail, RowMoveManager & CheckboxSelector) all at the same time. Our new project requires at least 2 of the 3 to be used together.
in order to achieve that, I added 2 new options to the Row Move Manager Plugin, the new options are (singleRowMove & disableRowSelection) and their default are set to false so it doesn't break anyone's code
the main changes are done in the RowMoveManager plugin, while a couple of changes were also made in the RowDetail Plugin so that all 3 plugins all work nicely together. A new Example was added as well to demo all 3 plugins in 1 grid, Cypress E2E were also added
add a way to use all 3 plugins at the same time
add
usabilityOverride
to skip move icon displayed on each row for the RowMoveManager Plugin (same override as all other plugins)add
getColumnDefinition()
method in the RowMoveManager Plugin with a custom formatter that is connected to the newusabilityOverride
add
grid
object to theargs
parameter ofonMoveRows
andonBeforeMoveRows
add Cypress E2E tests
See animated gif below for a demo
demo with
usabilityOverride
(RowMoveManager Plugin) to make only second rows moveable