-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rowDetail): add override method to know which row is expandable #351
Conversation
@SatanEnglish Also I'd like to know, there seems to be a - html.push('<div class="detail-container detailViewContainer_', dataContext.id, '" style="min-height:' + dataContext[_keyPrefix + 'height'] + 'px">');
+ html.push('<div class="detail-container detailViewContainer_', dataContext.id, '">'); With this change, the visual difference is shown below. Can I push this fix ( |
@ghiscoding I'll try have a play tomorrow. PS: Looks like I may have missed the 25px that are for the offset from min calculation.
Anyway I'll have a look at work. |
To stick with certain naming conventions, as mentioned in this comment, I've renamed the override method to |
@ghiscoding - html.push('<div class="detail-container detailViewContainer_', dataContext.id, '" style="min-height:' + dataContext[_keyPrefix + 'height'] + 'px">');
+ html.push('<div class="detail-container detailViewContainer_', dataContext.id, '">'); PS: Sorry took so long to check |
@SatanEnglish |
@ghiscoding Don't like the name as it doesn't explain itself. Guess my only question would be is there something nicer we can show than just a blank cell. |
Nicer as what? Are you expecting something to see something else when the row is not available instead of...nothing? Personally, I prefer to see nothing instead of a disabled element which user might not understand why it's disabled. |
@ghiscoding All good for now. For now you have done a great job. |
Similar to what we did with PR #346 on Row Selection with an override method, let's add the same feature to the Row Detail Expandable. The override method is named
expandableOverride
and follows the exact same concept as the PR #346Example