fix(selector): cell selector throws error in console when no scroll #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 7, 2019 12:28
- the error is not showing up if user tried scrolling at first, the small issue is related to the fact that 2 variables scrollTop, scrollLeft were not initialized
|
Nice job and sorry for missing initialization ! PS: which tool do you use to make small screen captures ? Screenpresso ? |
|
@mpegithub |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix a small issue found that the selection was incorrect on the top section (frozen) after scrolling in a non-frozen area. See animated gif
Relates to previous PR #331
Issue
After Fix
