fix(selection): copy text selection now working, closes #334

[ghiscoding]

• onSelectedRowsChanged should ONLY trigger when new selected rows are different compare to previously selected rows
• the issue comes from "slick.checkboxselectcolumn.js" that has a subscribe to "onSelectedRowsChanged" and when copying text selection, this was triggering a row selection (which is incorrect when row was already selected and doesn't change) and this in turn was calling an "invalidateRow" which finally removes focus of the cell

This fixes issue #334 (and possibly #150), in brief user cannot copy text selection when row is the selected row (even when it's the same selected row). Also note that I have enableTextSelectionOnCells enable but that was not helping with my issue. This was also mentioned in a very old issue #9, this PR fixes exactly that but at the source instead of in each plugins (checkbox selector was not covered in #9 fix).

Origin of the issue

handleSelectedRangesChanged was always triggering the event onSelectedRowsChanged, even when the row selected is exactly the same. That was doing a cascading effect of triggering handleSelectedRowsChanged of slick.checkboxselectcolumn.js, which inside had an grid.invalidateRow(row) that was doing the blur effect since the row was getting re-rendered and when that happens it obviously remove text selection focus since the DOM element gets recreated.

Fix

We should trigger an onSelectedRowsChanged event ONLY when the previously selected row(s) is not the same as the newly selected row(s) and that's it, we don't need to re-render and that fixes text selection.

Before the fix (I cannot keep text selection, it always blur away on the selected row)

With FIX

[ghiscoding]

@6pac
Once this PR is merged, would it be possible to release a new version on NPM? There are a few fixes that I'd like to use in my repos. Thanks

[6pac]

No probs, we are building up quite a few small changes. I'll leave the merging of this to you, let me know when you're ready for the release. (It is my custom to wait a day after the last pull for the inevitable patch).

[ghiscoding]

Thanks, you are definitely right about the last minute patches. I'll give another try in repos with latest merged code. I'll do that tomorrow.

[ghiscoding]

@6pac
You were right about the last minute patches, I did have to fix 2 small issues. I'm done with them and the testing, it's good on my side now, I'd be happy to see a new NPM version when you have a chance

[6pac]

Released 2.4.3

[ghiscoding]

Awesome, thanks 😃