Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gridmenu): should be using grid UID for menu independence #305

Merged
merged 1 commit into from
Dec 14, 2018
Merged

fix(gridmenu): should be using grid UID for menu independence #305

merged 1 commit into from
Dec 14, 2018

Conversation

ghiscoding
Copy link
Collaborator

  • without the fix, if 2 grids exists in the same page and 1 has header row showing, and the 2nd grid is not, 1 grid will affect the other. The fix is to use the grid UID to avoid such problems.

@ghiscoding
fix(gridmenu): should be using grid UID for menu independence
ee37691 
- without the fix, if 2 grids exists in the same page and 1 has header row showing, and the 2nd grid is not, 1 grid will affect the other. The fix is to use the grid UID to avoid such problems.
@ghiscoding ghiscoding merged commit c012add into master Dec 14, 2018
@ghiscoding ghiscoding deleted the bugfix/grid-menu-2-grids branch December 18, 2018 02:23
ghiscoding added a commit that referenced this pull request Dec 20, 2018
@ghiscoding
fix(gridmenu): should be using grid UID for menu independence (#305)
443d68d 
- without the fix, if 2 grids exists in the same page and 1 has header row showing, and the 2nd grid is not, 1 grid will affect the other. The fix is to use the grid UID to avoid such problems.
alhoo pushed a commit to alhoo/SlickGrid that referenced this pull request Dec 22, 2018
@ghiscoding
fix(gridmenu): should be using grid UID for menu independence (6pac#305)
00633bb 
- without the fix, if 2 grids exists in the same page and 1 has header row showing, and the 2nd grid is not, 1 grid will affect the other. The fix is to use the grid UID to avoid such problems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ghiscoding