updateRowCount shouldn't set virtual height when options.autoHeight is used #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghiscoding
added a commit
that referenced
this pull request
Apr 6, 2019
- supersede PR #209 - this fix avoid some grid using autoheight to go circular reference (2 references calling each other).
|
Thanks for the PR, I now see the problem in my own examples. Thanks again |
|
ok thanks, #365 looks good. |
|
huge thanks for sorting this one @ghiscoding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the virtual height
this used to updatehinupdateRowCount, but when filtering and autoHeight are usedoptions.rowHeight * numberOfRowscan be less than the current viewport height, sothis set to the existingviewportH - scrollbarDimensions.height.The problem in this case is that
his always set tooldHand soresizeCanvasdoesn't get called. This is only a problem on mobile browsers since there is no scrollbar height factored in, on desktop browsers the scrollbar height means thathdoes change andresizeCanvasdoes get called, but that is more of an accident than intentional... the answer anyway is not to use virtual height with the autoHeight option at all.