Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Cannot enable Push notifications, WalletConnect + Trust wallet and Argent wallet #480

Closed
phoebe-serveth opened this issue Jul 4, 2024 · 9 comments

Comments

@phoebe-serveth
Copy link
Collaborator

Issue Category

Other

What happened?

When enabling Push notifications, it opens trust wallet app but nothing happens. Owner key connected via Walletconnect + Trustwallet.
With argent wallet, the approve button is not clickable when enabling Push notifications.
image

Safe mobile app version: 3.26.0 (2015)
Device: iPhone 15, iOS version 17.5.1
I was able to replicate issue with Trust wallet with iOS version 17.4 as well.

Date and time this happened or you first noticed this issue

04-07-2024 8:00 pm

Network

Ethereum Mainnet

Safe Address

No response

Token Address

No response

Token Type

None

Transactions

No response

@schmanu
Copy link
Member

schmanu commented Jul 5, 2024

Sadly the notifications backend currently does not support 1271 at the moment. So it won't be possible to subscribe with Smart Accounts.

@CindyLo0
Copy link
Collaborator

CindyLo0 commented Jul 5, 2024

Hi @schmanu, need more info to relay to the user here. What is 1271, please?

@schmanu
Copy link
Member

schmanu commented Jul 5, 2024

In order to sign up for notifications the wallet has to sign a message. But currently we only support signatures which are made by private key based accounts. Not smart accounts. In order to validate signatures of smart accounts the EIP 1271 Standard has to be supported.

@CindyLo0
Copy link
Collaborator

CindyLo0 commented Jul 5, 2024

Thank you @schmanu. To clarify, this is only true if the wallet is TrustWallet SWIFT and Argent wallet which are both smart contracts but should still work with a Trustwallet created using secret phrase?

@mmv08
Copy link
Member

mmv08 commented Jul 5, 2024

Thank you @schmanu. To clarify, this is only true if the wallet is TrustWallet SWIFT and Argent wallet which are both smart contracts but should still work with a Trustwallet created using secret phrase?

That's correct

@phoebe-serveth
Copy link
Collaborator Author

phoebe-serveth commented Jul 5, 2024

Hi @schmanu, Thanks for the update. I did try to enable push notifications with trust wallet created via secret phrase that is imported via WalletConnect but nothing happens. It opens the trust wallet app but there is no prompt to sign or approve a message. Also tried to click on "Confirm to receive push notifications" upon importing keys but it's still not enabled.
image

@liliya-soroka
Copy link
Member

  1. Make sure that the network in the safe mobile app is the same as the networks in the Trust wallet
  2. as for push notifications enabling old "eth_sign" is used, you will need to allow it in the trust settings ->security to be able to use push notifications

@liliya-soroka
Copy link
Member

Any update from the user?

@Claire-serveth
Copy link
Collaborator

Claire-serveth commented Aug 26, 2024

Hi @liliya-soroka I can't seem to find the user's ticket. I'll go ahead and close this ticket for now and reopen should the issue still persists. Thank you 🙏

[It seems user was unresponsive hence the ticket was closed]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants