Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch: return error if select into gets empty #1459

Closed
vagetablechicken opened this issue Mar 15, 2022 · 1 comment · Fixed by #1621
Closed

batch: return error if select into gets empty #1459

vagetablechicken opened this issue Mar 15, 2022 · 1 comment · Fixed by #1621
Labels
good first issue Good for newcomers

Comments

@vagetablechicken
Copy link
Collaborator

vagetablechicken commented Mar 15, 2022

if (input.getDf().isEmpty) {
logger.info("select empty, skip save")
} else {

If select closure in select into result is empty, we just skip saving, and the job is succeed. But users can't find the output file. It's not intuitive.
We should throw an exception.

@vagetablechicken vagetablechicken changed the title batch: return error if s`elect into batch: return error if select into gets empty Mar 15, 2022
@vagetablechicken vagetablechicken added the good first issue Good for newcomers label Mar 15, 2022
@lumianph
Copy link
Collaborator

this issue belongs to our Contributor Challenges program, you can redeem your rewards after your PR is merged.
#1344

@lumianph lumianph linked a pull request Apr 13, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants