Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PZFPGA_ENABLE macro in cmd/openmldb.cc #1411

Closed
dl239 opened this issue Mar 10, 2022 · 2 comments · Fixed by #1418
Closed

Remove PZFPGA_ENABLE macro in cmd/openmldb.cc #1411

dl239 opened this issue Mar 10, 2022 · 2 comments · Fixed by #1418
Labels
good first issue Good for newcomers

Comments

@dl239
Copy link
Collaborator

dl239 commented Mar 10, 2022

PZFPGA_ENABLE is unused currently, we should remove it form cmd/openmldb.cc.
@dl239 dl239 added the good first issue Good for newcomers label Mar 10, 2022
@dl239 dl239 mentioned this issue Mar 10, 2022
Closed
@prashantpaidi
Copy link
Contributor

Can I work on this?

@dl239
Copy link
Collaborator Author

dl239 commented Mar 10, 2022 •
edited
Loading

Can I work on this?

of course, we are looking forward your pr. thank you @prashantpaidi

@prashantpaidi prashantpaidi mentioned this issue Mar 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove PZFPGA_ENABLE macro in cmd/openmldb.cc prashantpaidi/OpenMLDB
2 participants
@dl239 @prashantpaidi