Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spark connector: should handle the returns after write #1329

Closed
vagetablechicken opened this issue Feb 25, 2022 · 3 comments · Fixed by #1429
Closed

spark connector: should handle the returns after write #1329

vagetablechicken opened this issue Feb 25, 2022 · 3 comments · Fixed by #1429
Labels
good first issue Good for newcomers

Comments

@vagetablechicken
Copy link
Collaborator

OpenMLDB/java/openmldb-spark-connector/src/main/java/com/_4paradigm/openmldb/spark/write/OpenmldbDataWriter.java

Line 130 in 1aecdbc

preparedStatement.executeBatch();

executeBatch will return a list of int, 0 means ok, -1 means insert failed.
Read the list, if not all 0, throw an exception.
@vagetablechicken vagetablechicken added the good first issue Good for newcomers label Feb 25, 2022
@lumianph lumianph mentioned this issue Feb 28, 2022
Closed
@TheFu527
Copy link
Contributor

TheFu527 commented Mar 7, 2022

I would like to help.

@vagetablechicken
Copy link
Collaborator Author

I would like to help.

👍 If you need help, just ask for it.

@cswjd
Copy link
Contributor

cswjd commented Mar 11, 2022

I would like to help.

@lumianph lumianph linked a pull request Mar 12, 2022 that will close this issue
feat: check batch insert result in spark connector #1429
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: check batch insert result in spark connector cswjd/OpenMLDB
3 participants
@cswjd @vagetablechicken @TheFu527