We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Now the unit test of OpenmldbCatalogService is quite simple and lack of assertions. You can find the test code in https://github.com/4paradigm/OpenMLDB/blob/main/java/openmldb-batch/src/test/scala/com/_4paradigm/openmldb/batch/catalog/TestOpenmldbCatalogService.scala .
OpenmldbCatalogService
Now we can get all the table names from internal db. It would be better to add code in line 36 and check the table name like this using assertation.
val internalTableNames = List("JOB_INFO", "PRE_AGG_META_INFO") assert(internalTableNames.contains(tables(i)))
The text was updated successfully, but these errors were encountered:
Now we can get all the table names from internal db.
It would be better to add code in line 36 and check the table name like this.
Sorry, something went wrong.
I would like to work on this issue.
@tobegit3hub @lumianph I have raised a PR. Please review.
SaumyaBhushan
Successfully merging a pull request may close this issue.
Now the unit test of
OpenmldbCatalogService
is quite simple and lack of assertions. You can find the test code in https://github.com/4paradigm/OpenMLDB/blob/main/java/openmldb-batch/src/test/scala/com/_4paradigm/openmldb/batch/catalog/TestOpenmldbCatalogService.scala .Now we can get all the table names from internal db. It would be better to add code in line 36 and check the table name like this using assertation.
The text was updated successfully, but these errors were encountered: