Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth2: add support for the google service account json file #71

Open
macMikey opened this issue Jun 18, 2024 · 2 comments
Open

oauth2: add support for the google service account json file #71

macMikey opened this issue Jun 18, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@macMikey
Copy link
Contributor

when using oauth2 with a google service account, it would be simpler, if the dev could supply their google service account json file.
said file includes the following properties:

	  "type":
	  "project_id":
	  "private_key_id":
	  "private_key":
	  "client_email":
	  "client_id":
	  "auth_uri":
	  "token_uri":
	  "auth_provider_x509_cert_url":
	  "client_x509_cert_url":

this does not include every field that is required to request a jwt. for example, what you are calling the tenant (google calls it the sub), the scopes, and key would also be required to support a google service account.

@macMikey macMikey changed the title add support for the google service account json file oauth2: add support for the google service account json file Jun 18, 2024
@e-marchand e-marchand added the enhancement New feature or request label Jun 18, 2024
@macMikey
Copy link
Contributor Author

if you're cool with it, i propose changing the OAuth2Provicer class behavior as follows:
if name is "Google" and permission is "service", use a property called something like googleServiceAccountKey, or serviceAccountKey, which is the json that google gives you when you create a service account, and use that to populate the various properties of the object, including adding the jit header.

@macMikey
Copy link
Contributor Author

FYI, the service account key json is described here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants