Skip to content
This repository has been archived by the owner on Apr 22, 2020. It is now read-only.

General Library Upgrade #632

Merged
merged 1 commit into from
Sep 18, 2017
Merged

Conversation

juanpedromoreno
Copy link
Member

This PR:

  • Brings back sbt-microsites, once it has been cross versioned with sbt 1.0
  • Upgrades all the library catalog (we're releasing a new minor version since this upgrade might break binary compatibility)
  • Releases sbt-org-policies 0.7.0, to align it with the same minor version as sbt-microsites

after all libraries and plugins have been upgraded
Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@juanpedromoreno juanpedromoreno merged commit 52f25ce into master Sep 18, 2017
@juanpedromoreno juanpedromoreno deleted the jp-general-library-upgrade branch September 18, 2017 15:57
"h2" -> "1.4.196",
"http4s" -> "0.17.0-M3",
"joda-convert" -> "1.8.2",
"http4s" -> "0.18.0-M1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http4s 0.18.0-M1 depends on fs2 0.10.0-M6 and I'm not sure that it's binary compatible with fs2 0.9.7. It is okay?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for pointing it out @guersam

At this moment, this plugin sadly is not checking if libraries are binary compatible. However, when you are using the sbt-org-policies plugin and its dependency dsl, you can specify the version which fits better for your project.

For example:

%%("http4s") => by default will use the last one: "0.18.0-M1"

But you could use it in this way, to force the use of a different version of the artifact:

%%("http4s", "0.17.0-M3")

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created an issue because it would be great that plugin check it automatically: #638

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants