-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
Switch from publishSigned to publish for snapshot publishing. Bump sbt-pgp.
else | ||
sbt ^^$SBT_VERSION release; | ||
fi | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't like this and I'm open to ideas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's ok for a temporary solution. For a permanent solution, we could add a new sbt task
that checks the version internally and executes publish
or release
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
else | ||
sbt ^^$SBT_VERSION release; | ||
fi | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's ok for a temporary solution. For a permanent solution, we could add a new sbt task
that checks the version internally and executes publish
or release
.
@@ -63,7 +63,7 @@ trait bash { | |||
|
|||
val ref = extracted.get(thisProjectRef) | |||
|
|||
extracted.runAggregated[Unit](publishSigned in Global in ref, st) | |||
extracted.runAggregated[Unit](publish in Global in ref, st) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, but this would only affect to the orgPublishRelease
task
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In sbt 1.0:
All downstream projects that use orgAfterCISuccess
depend on orgPublishReleaseTask
/orgPublishRelease
, as far as I can tell. If orgAfterCISuccess
is called on "master" with a SNAPSHOT
version, publishSigned
will break for the second push/merge because overwrite = false
.
https://github.com/sbt/sbt-pgp/blob/master/pgp-plugin/src/main/scala-sbt-1.0/Compat.scala#L72
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @suhasgaddam !
No description provided.