Skip to content
This repository has been archived by the owner on Apr 22, 2020. It is now read-only.

CI 0.6.0 snapshot #512

Merged
merged 2 commits into from
Sep 11, 2017
Merged

CI 0.6.0 snapshot #512

merged 2 commits into from
Sep 11, 2017

Conversation

suhasgaddam
Copy link
Contributor

No description provided.

Switch from publishSigned to publish for snapshot publishing. Bump
sbt-pgp.
@suhasgaddam suhasgaddam changed the title Ci 0.6.0 snapshot CI 0.6.0 snapshot Sep 11, 2017
else
sbt ^^$SBT_VERSION release;
fi
fi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't like this and I'm open to ideas.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok for a temporary solution. For a permanent solution, we could add a new sbt task that checks the version internally and executes publish or release.

Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

else
sbt ^^$SBT_VERSION release;
fi
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok for a temporary solution. For a permanent solution, we could add a new sbt task that checks the version internally and executes publish or release.

@@ -63,7 +63,7 @@ trait bash {

val ref = extracted.get(thisProjectRef)

extracted.runAggregated[Unit](publishSigned in Global in ref, st)
extracted.runAggregated[Unit](publish in Global in ref, st)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but this would only affect to the orgPublishRelease task

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In sbt 1.0:

All downstream projects that use orgAfterCISuccess depend on orgPublishReleaseTask/orgPublishRelease, as far as I can tell. If orgAfterCISuccess is called on "master" with a SNAPSHOT version, publishSigned will break for the second push/merge because overwrite = false.

https://github.com/sbt/sbt-pgp/blob/master/pgp-plugin/src/main/scala-sbt-1.0/Compat.scala#L72

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @suhasgaddam !

@suhasgaddam suhasgaddam merged commit 45fe4a5 into master Sep 11, 2017
@suhasgaddam suhasgaddam deleted the ci-0.6.0-snapshot branch September 11, 2017 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants