Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare proper doctype on layouts #430

Merged
merged 3 commits into from
Feb 20, 2020
Merged

Declare proper doctype on layouts #430

merged 3 commits into from
Feb 20, 2020

Conversation

calvellido
Copy link
Contributor

  • Add a proper doctype declaration <!DOCTYPE html> to all layouts when they are generated thought the render method of their TypedTag.
  • Update some copyright notices.

This closes #427

@calvellido calvellido added the enhancement New feature or request label Feb 20, 2020
BenFradet
BenFradet approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@calvellido
Copy link
Contributor Author

calvellido commented Feb 20, 2020 •
edited
Loading

Thanks @BenFradet!

@calvellido calvellido merged commit 04e8136 into master Feb 20, 2020
@calvellido calvellido deleted the jv-427-doctype branch February 20, 2020 16:09
@calvellido calvellido mentioned this pull request Mar 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenFradet BenFradet BenFradet approved these changes

@jdesiloniz jdesiloniz Awaiting requested review from jdesiloniz

@juanpedromoreno juanpedromoreno Awaiting requested review from juanpedromoreno

@AntonioMateoGomez AntonioMateoGomez Awaiting requested review from AntonioMateoGomez

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Layouts are not declaring its doctype 🤦
2 participants
@calvellido @BenFradet