-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the site absolute url for twitter:image #285
Conversation
Apologies for hijacking, but would it be possible to also fix og:image for linkedin in this PR? Not sure if an absolute URL is also needed here or if the format of |
@manosbatsis Added fixes for Linked-in as well. I've added properties for og:image and og:title properties, and confirmed it's working well: https://www.linkedin.com/post-inspector/inspect/https:%2F%2Fwvlet.org%2Fairframe%2F |
That's fantastic, many thanks @xerial - looking forward to 0.7.26! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @xerial! Would you mind to add that new config parameter to the docs? Basically this file: settings.md
A simple description on why that parameter might be useful would suffice.
OK! |
@calvellido Added a note to settings.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 👏 👏
Just released 0.7.26 including these changes, thanks so much @xerial! |
Grand, thanks guys @calvellido and @xerial |
Hm, still can't see the new version on central after six hours or so. @calvellido this normal? |
It failed: https://travis-ci.org/47deg/sbt-microsites/jobs/457450111#L1488 I'll fix it. |
0.7.26 should be now on its way to Maven central. |
@juanpedromoreno confirmed, cheers |
Thanks @juanpedromoreno! 😘 |
#283 didn't truly fix the issue because Twitter requires absolute URLs for images.
This PR adds a new configuration
micrositeUrl
when we need to specify the site absolute url.Alternative approaches:
site.url
. But if we set this value in _config.yml, it makes difficult to see local images updates because there are many templates using{{site.url}}
(e.g., favicon URLs), so all icon images refer remote server URLs.With this fix, the card validator https://cards-dev.twitter.com/validator of Twitter icon can properly show the card image (/image/poster.png):