Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitSiteURL supports MicrositeKeys.GitHub and gitHostingUrl #272

Merged
merged 2 commits into from
Jul 15, 2018

Conversation

britneywright
Copy link
Contributor

I'm working with sbt-microsites on projects that are hosted on private Github instances. Currently the gitSiteUrl sets the URL to github.com if GitHub is the gitHostingService. This means I can't correctly link to my hosted Github repos with the default links in the template header, footer, and homepage.

This pull request updated the gitSiteUrl to check the gitHostingService and gitHostingUrl attributes. If it is MicrositeKeys.GitHub and an empty string it returns the existing formatted URL, otherwise it returns the user set gitHostingUrl.

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @britneywright ! Code looks good 👍

Please, would you mind to add this to the docs?
https://47deg.github.io/sbt-microsites/docs/settings.html

I guess that we could explain this behaviour where the micrositeGitHostingService and micrositeGitHostingUrl settings keys are mentioned.
Thanks!

@britneywright
Copy link
Contributor Author

Thanks @juanpedromoreno. I added an update to the docs.

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks 👍

@juanpedromoreno juanpedromoreno merged commit 54be8cb into 47degrees:master Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants