[upstream] support path in the upstream url #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
force-pushed
the
upstream-path-spec
branch
3 times, most recently
from
30df666 to
8967e37
Compare
Route traffic to that path + current url.
mikz
force-pushed
the
upstream-path-spec
branch
from
8967e37 to
fe6faad
Compare
mikz
commented
Sep 26, 2018
| } | ||
| --- request | ||
| GET /some_path?user_key=uk&a_param=a_value | ||
| --- response_body | ||
| yay, api backend | ||
| GET /path_in_the_rule/some_path?user_key=uk&a_param=a_value HTTP/1.1 |
There was a problem hiding this comment.
Technically this is a breaking change as it used to be GET /path_in_the_rule.
But I was thinking that the upstream policy needs some improvements anyway. For example, stripping the path that it matched from the URL etc. So we can make general improvements to that policy and make it configurable how it operates on URI paths.
davidor
approved these changes
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Route traffic to that path + current url.
Closes #903