Expose jwt in the policies context #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidor
changed the title
davidor
force-pushed
the
expose-jwt-tokens-context
branch
from
01cebd8 to
0ed50f1
Compare
davidor
changed the title
mikz
reviewed
May 18, 2018
t/apicast-policy-headers.t
Outdated
| # Make fixtures policies available. There is a test that needs the "decode | ||
| # oidc token" example policy. | ||
| BEGIN { | ||
| $ENV{TEST_NGINX_APICAST_POLICY_LOAD_PATH} = 't/fixtures/policies'; |
davidor
force-pushed
the
expose-jwt-tokens-context
branch
from
258c116 to
8470225
Compare
davidor
commented
May 18, 2018
| { | ||
| "issuer": "https://example.com/auth/realms/apicast", | ||
| "config": { | ||
| "public_key": "MFwwDQYJKoZIhvcNAQEBBQADSwAwSAJBALClz96cDQ965ENYMfZzG+Acu25lpx2KNpAALBQ+catCA59us7+uLY5rjQR6SOgZpCz5PJiKNAdRPDJMXSmXqM0CAwEAAQ==", |
There was a problem hiding this comment.
@mikz Ideas to avoid hardcoding it here?
There was a problem hiding this comment.
You can do eval filter and use Perl to read it and interpolate it.
There was a problem hiding this comment.
this could possibly work:
<<"JSON";
{
"oidc": ...
"public_key": "$::rsa"
}
JSON
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes jwt in the policies context in OAuth flows.
This is useful because it allows other policies to access those tokens. For example, the rate-limit policy ( #713 ) could benefit from this.
This PR also adds an integration test that uses OAuth and the headers policy and shows how it can set some headers with information extracted from the decoded jwt.