[cli] generate command to create scaffolding #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
force-pushed
the
policy-scaffolding
branch
2 times, most recently
from
75403a1 to
db335a5
Compare
davidor
reviewed
May 7, 2018
| -- This is a {{ policy.name }} description. | ||
|
|
||
| local policy = require('apicast.policy') | ||
| local _M = policy.new('{{ policy.summary }}') |
There was a problem hiding this comment.
Shouldn't this be policy.name ?
There was a problem hiding this comment.
Yep. It should be some human name.
davidor
reviewed
May 7, 2018
gateway/Roverfile.lock
Outdated
| @@ -1,4 +1,4 @@ | |||
| argparse 0.5.0-1||production | |||
| argparse 0.6.0-1||production | |||
There was a problem hiding this comment.
Do we need the new version for some reason?
There was a problem hiding this comment.
No good reason. rover is not so smart about releasing locked versions.
davidor
reviewed
May 7, 2018
|
|
||
| local directory = function(dir) if pl.path.dir(dir) then return pl.path.abspath(dir) end end | ||
|
|
||
| return function(parser) |
There was a problem hiding this comment.
I think the option for summary is missing.
davidor
reviewed
May 7, 2018
|
|
||
| function _M.copy(source, destination, env, force) | ||
| print('source: ', source) | ||
| print('destinatioon: ', destination) |
|
Looks good 👍 Can you mention this option somewhere in the |
mikz
changed the title
* create templated files and directories to make it easier to create new policies, cli commands, etc.
davidor
approved these changes
May 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to replace the need to copy-paste with scaffolding.