Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[t] use Test::APIcast from CPAN #528

Merged
merged 2 commits into from
Dec 20, 2017
Merged

[t] use Test::APIcast from CPAN #528

merged 2 commits into from
Dec 20, 2017

Conversation

mikz
Copy link
Contributor

@mikz mikz commented Dec 12, 2017

be aware this increases the CI build time (s2i builder+runtime) significantly as there are dependencies that have to be pulled

@mikz mikz force-pushed the cpan-test-apicast branch 7 times, most recently from 8bae095 to 205ef08 Compare December 12, 2017 13:38
@mikz mikz force-pushed the cpan-test-apicast branch 3 times, most recently from b1ba5ae to 757d164 Compare December 12, 2017 15:05
@@ -1,5 +1,5 @@
use lib 't';
use TestAPIcast 'no_plan';
use Test::APIcast 'no_plan';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This namespace looks a bit strange to me. Is it common in Perl to start testing libraries with Test::?
I guess that's it, because we also have Test::Nginx.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. And there is Test::Simple and Test::More.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davidor
Copy link
Contributor

davidor commented Dec 19, 2017

👍
remember to fix the changelog conflict before merging :)

@mikz mikz force-pushed the cpan-test-apicast branch from 757d164 to 521ae49 Compare December 19, 2017 15:37
mikz added 2 commits December 19, 2017 16:41
* install it with cpanminus
* can be used outside APIcast repository
@mikz mikz force-pushed the cpan-test-apicast branch from 521ae49 to 5230f6e Compare December 19, 2017 15:41
@mikz mikz requested a review from davidor December 19, 2017 15:56
@davidor davidor merged commit 307adae into master Dec 20, 2017
@davidor davidor deleted the cpan-test-apicast branch December 20, 2017 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants