Set correct status code of the error on token store fail #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayorova
force-pushed
the
fix-oauth-store-token-code
branch
from
468f2eb to
cfe6010
Compare
mayorova
force-pushed
the
fix-oauth-store-token-code
branch
from
cfe6010 to
a4534dc
Compare
mikz
approved these changes
Sep 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the native OAuth flow, when storing access token in 3scale backend fails, currently a
200status code is returned. It doesn't seem to be the desired behavior, as there's the following line:It also provokes the following warning message:
This PR fixes it, and returns to the client the status code that was returned by the 3scale backend on token store attempt.