Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Describe module inheritance #308

Closed
mikz opened this issue Mar 16, 2017 · 0 comments · Fixed by #362
Closed

Describe module inheritance #308

mikz opened this issue Mar 16, 2017 · 0 comments · Fixed by #362
Assignees
@mikz

Comments

@mikz
Copy link
Contributor

mikz commented Mar 16, 2017

When writing custom modules it is desired to call the parent module (apicast) and just extend it with new behaviour.

As #307 showed this is not well described, defined or implemented. It requires some boilerplate in the module to ensure inheritance chain.

We should:

  • write unit tested examples of module inheritance
  • try to come up with best interface for inheriting
  • ensure it is still JITable
@mikz mikz mentioned this issue Mar 16, 2017
Merged
@mikz mikz self-assigned this Mar 21, 2017
@octobot octobot added the T-obux label Mar 21, 2017
@ghost ghost added the B-current label May 5, 2017
@mikz mikz mentioned this issue May 5, 2017
Merged
@mikz mikz closed this as completed in #362 May 11, 2017
@ghost ghost removed the B-current label May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikz mikz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

describe module inheritance 3scale/APIcast
2 participants
@mikz @octobot