From 3792d96e84a7a37394e559b25b10cc4a808a70a9 Mon Sep 17 00:00:00 2001 From: Roman Perekhod Date: Tue, 24 Sep 2024 11:12:49 +0200 Subject: [PATCH] Permission denied is now backing the request. --- changelog/unreleased/fix-app-new-response-add.md | 5 +++++ internal/http/services/appprovider/appprovider.go | 1 + 2 files changed, 6 insertions(+) create mode 100644 changelog/unreleased/fix-app-new-response-add.md diff --git a/changelog/unreleased/fix-app-new-response-add.md b/changelog/unreleased/fix-app-new-response-add.md new file mode 100644 index 0000000000..a64d34247c --- /dev/null +++ b/changelog/unreleased/fix-app-new-response-add.md @@ -0,0 +1,5 @@ +Bugfix: Better response codes for app new endpoint + +We fixed the response codes for the app new endpoint. Permission denied is now backing the request. + +https://github.com/cs3org/reva/pull/4865 diff --git a/internal/http/services/appprovider/appprovider.go b/internal/http/services/appprovider/appprovider.go index cf017503a1..75d9e7ac9c 100644 --- a/internal/http/services/appprovider/appprovider.go +++ b/internal/http/services/appprovider/appprovider.go @@ -254,6 +254,7 @@ func (s *svc) handleNew(w http.ResponseWriter, r *http.Request) { switch createRes.Status.Code { case rpc.Code_CODE_PERMISSION_DENIED: writeError(w, r, appErrorPermissionDenied, "permission denied to create the file", nil) + return case rpc.Code_CODE_NOT_FOUND: writeError(w, r, appErrorNotFound, "parent container does not exist", nil) return