Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in phpredis 4.0 #9

Closed
ud-klee opened this issue Mar 29, 2018 · 2 comments
Closed

Breaking change in phpredis 4.0 #9

ud-klee opened this issue Mar 29, 2018 · 2 comments

Comments

@ud-klee
Copy link

ud-klee commented Mar 29, 2018

According to phpredis/phpredis#1323 Redis::exists() is now returning integer instead of bool, which breaks

&& false === $this->redis->exists($session_id);

Any plans of supporting the newer extension? And perhaps add this info to the known caveats section.

Thanks.

@1ma
Copy link
Owner

1ma commented Mar 29, 2018

Thank you for the heads up. I'll see if I can support both 3.x and 4.x seamlessly.

@1ma
Copy link
Owner

1ma commented Mar 31, 2018

In the end that was easy enough, it only involved a boolean casting. I just released version 0.9.6 of the handler, which contains this fix.

Cheers.

@1ma 1ma closed this as completed Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants