Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode: settings.json and REST client not supported #188

Open
tschifftner opened this issue Nov 22, 2023 · 2 comments
Open

VSCode: settings.json and REST client not supported #188

tschifftner opened this issue Nov 22, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@tschifftner
Copy link

Your environment

op-vscode version: v1.0.4

VS Code version: October 2023 (version 1.84)

CLI version: 2.23.0

OS: Mac OS

Steps to reproduce

  1. First I tried to add secret reference to settings.json
"rest-client.environmentVariables": {
    "$shared": {
      "version": "v1",
      "basicAuth": ""
    },
    "1Password test": {
      "username": "test",
      "password": "op://Vault/uns2wilfuzxoh4n7nedihyaavu/password",
    }
  },
  1. Then I tried direct usage in test.http file, one single value at a time
@host = https://example.com/api
@password = "op://Vault/uns2wilfuzxoh4n7nedihyaavu/password",

### login
# @name postLogin
POST {{ host }}/oauth/v1/token
Authorization: Basic op://Vault/uns2wilfuzxoh4n7nedihyaavu/token
Content-Type: application/json

{
    "grant_type": "password",
    "username": "op://Vault/uns2wilfuzxoh4n7nedihyaavu/username",
    "password": "{{password}}"
}

REST plugin can be found here: https://marketplace.visualstudio.com/items?itemName=humao.rest-client

What happened?

The secret values were not used

What did you expect to happen?

I expected to work with the passwords from 1password

Notes & Logs

@tschifftner tschifftner added the bug Something isn't working label Nov 22, 2023
@jodyheavener
Copy link
Member

Hi @tschifftner, doing some issue triage here. I don't believe this is a bug, but rather more suitable as a feature request. It will take some work to make this extension compatible with the one you've noted. Thank you for bringing it to our attention!

@jodyheavener jodyheavener added enhancement New feature or request and removed bug Something isn't working labels May 23, 2024
@alias-lightheart
Copy link

@jodyheavener I am currently going to make a pull request to add the REST Client extension. I need to use 1Password with REST Client for a product of mine, thanks!

Best Regards,
kuiperonit (Austin Riddolls)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants