[staging] merge v1.3.0 #1253
Merged
[staging] merge v1.3.0 #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In one very specific case, tooltips were being removed from the page when new search results were rendered. This fixes that issue by stashing a reference to the tooltip's "original parent" and returning it to that element when the tooltip is hidden, so that if the element in which it was shown is removed, the tooltip isn't removed with it.
This moves setting the `previousParams` variable to *after* a request is successfully made, which avoids a specific issue with pagination in the case that the user: 1. visits a specific page in the results, 2. modifies the search criteria, and 3. modifies the search criteria again before the second request returns. Previously, the comparison of the changed parameters between steps 2 and 3 would *not* trigger a page reset.
Optimize pdf assets
Updates links in footer
Removed the word leading
This started as an IE11 bug fix and ended as a performance optimization. IE11 was throwing untraceable errors somewhere inside tagalong() with the long list of template directives specified in `picc.school.directives`. These are all used on the school page (where they appear not to be a problem), but on search we only use a small subset of them to render each result item, so we use a subset of the directive keys. This improves performance and appears to resolve the IE11 crashes when rendering new data after a change to search criteria.
This change introduces a bit of code that removes all of the elements that get updated when the search results come back. Specifically, I think that IE was crashing in cases when the number of items changed (possibly only when it decreased), so to avoid the rudimentary "data join" logic in tagalong, we just remove all of the children of the results list before calling tagalong(). The important thing to note here is that **we only do this in IE *and* if results have been loaded already**. In that case, tagalong has already stashed a reference to the "template" node that gets used to render each result item, so removing all of the children is safe. (This is what happens when we get a zero-length result set anyway.)
IE11 and misc. search fixes
added 2 commits
September 9, 2015 16:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the release notes (or the diff below) for what's changed.