Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future incompatibility with MPL #43

Closed
neutrinoceros opened this issue Aug 20, 2022 · 3 comments · Fixed by #44
Closed

Future incompatibility with MPL #43

neutrinoceros opened this issue Aug 20, 2022 · 3 comments · Fixed by #44
Labels
feature request New idea or feature request

Comments

@neutrinoceros
Copy link
Collaborator

Just wanted to warn you about the pending deprecation of some functions in the matplotlib.cm namespace that are used in cmasher, like get_cmap

matplotlib/matplotlib#23668

If it's any help, here's the patch I wrote to adapt to these deprecations in yt
yt-project/yt#4089

I can also submit a PR here if you lack time for this.

@neutrinoceros neutrinoceros added the feature request New idea or feature request label Aug 20, 2022
@1313e
Copy link
Owner

1313e commented Aug 20, 2022

@neutrinoceros Thanks for the heads up.
I will make the changes for this soon.

@1313e
Copy link
Owner

1313e commented Sep 6, 2022

@neutrinoceros Well, I said I would do it soon, but it seems I cannot find the time to sit down and do this.
So, if you wish, you can open a PR with the required changes for it.

@blakeNaccarato
Copy link

blakeNaccarato commented Aug 2, 2023

I opened another PR against this issue to resolve DeprecationWarnings involving the use of mplcm.get_cmap and mplcm.register_cmap. I made the minimal necessary changes in code and tests. I left CMasher's mirror implementations for getting and registering colormaps untouched, and just changed the underlying calls to non-deprecated approaches.

EDIT: See my latest comment in my PR for details, but I realize this was duplicating work in the PR merged out of master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New idea or feature request
Projects
None yet
3 participants