Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider porting core to rescript lang #1447

Closed
ghost opened this issue Oct 14, 2020 · 7 comments
Closed

consider porting core to rescript lang #1447

ghost opened this issue Oct 14, 2020 · 7 comments

Comments

@ghost
Copy link

ghost commented Oct 14, 2020

Of the static site gen space, I like 11ty's philosophy. Consider adopting rescript/reason as your implementation language to get more compile time assurances. Will close immediately, just want to leave this note.

@ghost ghost added the enhancement label Oct 14, 2020
@ghost ghost closed this as completed Oct 14, 2020
@Ryuno-Ki
Copy link
Contributor

@kanishka-azimi If you want to give it a try, this might help: #1422 (comment)
Otherwise, upvote #117, please.

@ghost
Copy link
Author

ghost commented Oct 14, 2020

Close, but I mean more for the engine / core, not just templating

@ghost
Copy link
Author

ghost commented Oct 15, 2020

I might get approval to spend a few days providing a proof of concept of converting to rescript/reason for a few source files. Do you see any chance of such a PR getting accepted?

@ghost ghost changed the title consider rescript lang consider porting core to rescript lang Oct 15, 2020
@binyamin
Copy link
Member

@kanishka-azimi We need @zachleat's thoughts on this, as he's the core contributor and maintainer. Also, he's very busy at the moment, so the PR could sit un-merged for a while. I don't want you to do work which won't get merged. But if Zach is okay with this, go ahead.

@ghost
Copy link
Author

ghost commented Oct 15, 2020

Don't mind if it's unmeged for a while. If it sounds acceptable, just note what you consider the least important or least changing source file(s), so I can focus there

@ghost
Copy link
Author

ghost commented Oct 15, 2020

Cc @roddyyaga

@ghost
Copy link
Author

ghost commented Dec 15, 2020

FYI, there is also this template engine example using reasonml: https://johnridesa.bike/acutis/ . The author uses it with eleventy's custom plugin api currently.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants