Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hook, using media_buttons instead of media_buttons_context #147

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Update hook, using media_buttons instead of media_buttons_context #147

merged 2 commits into from
Oct 28, 2021

Conversation

debabratakarfa
Copy link
Contributor

@debabratakarfa debabratakarfa commented Sep 21, 2021 •
edited by jeffpaul
Loading

Description of the Change

media_buttons_context hook has been deprecated, using media_buttons action instead. Originally reported on WordPress.org.

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Checklist:

  • [x ] I have read the CONTRIBUTING document.
  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

@debabratakarfa
Update hooks
1c70aa9 
`media_buttons_context`  hook has been deprecated, using `media_buttons` action instead.
@jeffpaul jeffpaul added this to the Future Release milestone Sep 21, 2021
@jeffpaul
Copy link
Member

Pinging a couple folks here to see if one can help review this. Once its passed code review we can look to milestone in a numbered release. Thanks for the WP.org support issue and opening the PR @debabratakarfa!

@jeffpaul
Copy link
Member

@rickalee @colegeissinger @thrijith any feedback on your review here?

colegeissinger
colegeissinger requested changes Oct 15, 2021
View reviewed changes
Copy link
Member

@colegeissinger colegeissinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good minus one spot that needs to be fixed. Once that is fixed I can approve this PR for merge.

windows-azure-storage.php Outdated Show resolved Hide resolved
@colegeissinger
Copy link
Member

Thank you! This looks good from my end!

@jeffpaul jeffpaul modified the milestones: Future Release, 4.4.0 Oct 28, 2021
@jeffpaul jeffpaul merged commit 7c0262a into 10up:develop Oct 28, 2021
@jeffpaul jeffpaul modified the milestones: 4.4.0, 4.3.3 Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colegeissinger colegeissinger colegeissinger approved these changes

@thrijith thrijith Awaiting requested review from thrijith

@rickalee rickalee Awaiting requested review from rickalee rickalee is a code owner

Assignees

@debabratakarfa debabratakarfa

Labels
None yet
Projects
None yet
Milestone
4.3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@debabratakarfa @jeffpaul @colegeissinger