Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Installation Workflow and initial sync #2706

Closed
2 tasks done
felipeelia opened this issue Apr 8, 2022 · 2 comments · Fixed by #2738
Closed
2 tasks done

BUG: Installation Workflow and initial sync #2706

felipeelia opened this issue Apr 8, 2022 · 2 comments · Fixed by #2738
Assignees
Labels
confirmed bug module:installation Issues related to the install process
Milestone

Comments

@felipeelia
Copy link
Member

felipeelia commented Apr 8, 2022

Describe the bug

There are actually two:

  • During the installation process, if the user does not select any feature during step 3, the "Save Feature" button only reloads the page.
  • During the initial sync (the one automatically made after clicking on the step 4 button), the screen won't be properly set as done, i.e., make the progress bar green and hide the pause/stop buttons. (There is a chance this is fixed by Sync Page JS #2704)

Additional context

This can be reproduced in an easier way using code from #2705.

Credits

Props @jakemgold.

@felipeelia felipeelia added the bug Something isn't working label Apr 8, 2022
@felipeelia felipeelia added this to the 4.2.0 milestone Apr 8, 2022
@felipeelia felipeelia added confirmed bug module:installation Issues related to the install process needs discussion and removed bug Something isn't working labels Apr 8, 2022
@brandwaffle
Copy link
Contributor

@tlovett1 are you thinking if someone checks none of the boxes we should warn them that nothing will be active and then move past install, or should we be indicating we're requiring they check at least one box?

@JakePT
Copy link
Contributor

JakePT commented Apr 21, 2022

@felipeelia As discussed with @brandwaffle we will address the first point by displaying a standard browser alert that reads:

It looks like you’re trying to use ElasticPress’s advanced features only. If you’d like to activate basic search, please select Cancel and activate the Post Search Feature. Otherwise, please click Ok to configure advanced features.

And continuing will proceed to the Features page without starting a sync.

@JakePT JakePT mentioned this issue May 3, 2022
6 tasks
@JakePT JakePT linked a pull request May 3, 2022 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed bug module:installation Issues related to the install process
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants