INT-379: Fix config so windows actually builds. #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, this looks pretty much what I had on tree/fix-windows. But that wasn't sufficient for me last week, even with electron-0.30.4. Will test ASAP. |
|
Tested on Evergreen: https://evergreen.mongodb.com/task/scout_windows_64_compile_60a545e8c09a2ffcc5b7f8fc5c86467db558bf2f_15_08_29_16_12_49 It worked, but the final s3.put stage has the wrong path. I'll fix that separately. |
kangas
added a commit
that referenced
this pull request
Aug 29, 2015
INT-379: Fix config so windows actually builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some metadata munging needed. After running
npm run release, you'll get the following files:cc @kangas