Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the 3.0.9 release from the 4.x NPM bundle #1632

Closed
ronyeh opened this issue Aug 22, 2024 · 0 comments · Fixed by #1634
Closed

Remove the 3.0.9 release from the 4.x NPM bundle #1632

ronyeh opened this issue Aug 22, 2024 · 0 comments · Fixed by #1634
Assignees

Comments

@ronyeh
Copy link
Collaborator

ronyeh commented Aug 22, 2024

We had been keeping around the legacy version of VexFlow (v 3.0.9) in the releases/ directory.

This was because some old websites and old JSFiddles that depended on v3.0.9 linked directly to:
https://unpkg.com/vexflow/releases/vexflow-min.js

If we had removed the releases/ directly when we published v4.x, we would have broken those old sites. Even if we put v4.x into the releases/ directory (overwriting 3.0.9), we would have broken those old sites, since 4.x introduced breaking changes.

It's confusing that we ship the legacy version alongside the current one in the build/ directory.

4.x has been out long enough now (and we're working on 5.x). I think it's time we remove that releases/ folder. It's okay if those older JSFiddles break. :-)

I'll introduce a PR to remove the releases/ folder from the NPM package.

Originally posted by @ronyeh in #1630 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant