Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some duplicated images when running grunt test:reference #1483

Closed
ronyeh opened this issue Dec 8, 2022 · 1 comment · Fixed by #1503
Closed

Some duplicated images when running grunt test:reference #1483

ronyeh opened this issue Dec 8, 2022 · 1 comment · Fixed by #1503
Labels

Comments

@ronyeh
Copy link
Collaborator

ronyeh commented Dec 8, 2022

Currently, the Gruntfile.js runs generate_images.js without specifying the --backends option.

This means that we generate images with both JSDOM and Puppeteer.

This results in some duplicate work. For example, in the build/images/current/ folder, we have:

Rests.Dotted.Gonville.png
pptr-canvas_Rests.Dotted.Bravura.png
pptr-Rests.Dotted.Bravura.svg
pptr-Rests.Dotted.Bravura.svg.png
pptr-Rests.Dotted.Gonville.svg
pptr-Rests.Dotted.Gonville.svg.png
pptr-Rests.Dotted.Leland.svg
pptr-Rests.Dotted.Leland.svg.png
pptr-Rests.Dotted.Petaluma.svg
pptr-Rests.Dotted.Petaluma.svg.png
Rests.Dotted.Bravura.png
Rests.Dotted.Petaluma.png

pptr-Rests.Dotted.Petaluma.svg.png and Rests.Dotted.Petaluma.png are nearly visually identical, which is a good thing. :-)

But perhaps this means we can turn off jsdom when generating these test images, and use pptr exclusively. That might speed up the testing process a bit.

@rvilarl
Copy link
Collaborator

rvilarl commented Dec 10, 2022

I agree, it would be better one default method and not three, when no method is selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants