Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter tokens in prices which do not exist on the network #265

Merged
merged 1 commit into from
Jun 21, 2020

Conversation

dekz
Copy link
Member

@dekz dekz commented Jun 21, 2020

Description

Prevent the sampler being queried for tokens which aren't relevant to the network.

{
  "records": [
    {
      "symbol": "DAI",
      "price": "0.004393625785289904"
    },
    {
      "symbol": "REP",
      "price": "0.076538996520002342"
    },
    {
      "symbol": "ZRX",
      "price": "0.001540893389947478"
    },
    {
      "symbol": "USDC",
      "price": "0.004377"
    },
    {
      "symbol": "BAT",
      "price": "0.001012320828012612"
    },
    {
      "symbol": "MKR",
      "price": "2.291829546186608791"
    },
    {
      "symbol": "WBTC",
      "price": "41.0183714"
    },
    {
      "symbol": "SNX",
      "price": "0.005889644261233945"
    },
    {
      "symbol": "SUSD",
      "price": "0.004335665696650417"
    },
    {
      "symbol": "KNC",
      "price": "0.005649200762120254"
    },
    {
      "symbol": "BNT",
      "price": "0.00382540038818005"
    },
    {
      "symbol": "GNO",
      "price": "0.132973201495201436"
    },
    {
      "symbol": "LINK",
      "price": "0.018326004433407458"
    },
    {
      "symbol": "REN",
      "price": "0.000515010322100098"
    },
    {
      "symbol": "OMG",
      "price": "0.006104994303656681"
    },
    {
      "symbol": "ANT",
      "price": "0.005340941438739387"
    },
    {
      "symbol": "SAI",
      "price": "0.005138907154811671"
    },
    {
      "symbol": "CVL",
      "price": "0.000015167807600922"
    },
    {
      "symbol": "DTH",
      "price": "0.000010279834814145"
    },
    {
      "symbol": "FOAM",
      "price": "0.000076406549692151"
    },
    {
      "symbol": "AST",
      "price": "0.0002"
    },
    {
      "symbol": "GEN",
      "price": "0.00040919369188536"
    },
    {
      "symbol": "STORJ",
      "price": "0.00083755"
    },
    {
      "symbol": "MANA",
      "price": "0.000183541949676556"
    },
    {
      "symbol": "ENTRP",
      "price": "0.006636527197738544"
    },
    {
      "symbol": "LOOM",
      "price": "0.0000934146310997"
    },
    {
      "symbol": "CELR",
      "price": "0.000016480243365516"
    },
    {
      "symbol": "RLC",
      "price": "0.002718821"
    },
    {
      "symbol": "DGD",
      "price": "0.562166107"
    },
    {
      "symbol": "ZIL",
      "price": "0.000086676098"
    },
    {
      "symbol": "cBAT",
      "price": "0.00001801"
    },
    {
      "symbol": "cDAI",
      "price": "0.00008833"
    },
    {
      "symbol": "cSAI",
      "price": "0.00010747"
    },
    {
      "symbol": "cETH",
      "price": "0.02335214"
    },
    {
      "symbol": "cUSDC",
      "price": "0.00009306"
    },
    {
      "symbol": "cZRX",
      "price": "0.00004083"
    },
    {
      "symbol": "0xBTC",
      "price": "0.00044409"
    },
    {
      "symbol": "SNT",
      "price": "0.000112094322457333"
    },
    {
      "symbol": "SPANK",
      "price": "0.000011844192643364"
    },
    {
      "symbol": "BOOTY",
      "price": "0.005583210338351067"
    },
    {
      "symbol": "UBT",
      "price": "0.00162899"
    },
    {
      "symbol": "NMR",
      "price": "0.103799658070175002"
    },
    {
      "symbol": "GUSD",
      "price": "0.01"
    },
    {
      "symbol": "FUN",
      "price": "0.00001683"
    },
    {
      "symbol": "PAX",
      "price": "0.004352530171682399"
    },
    {
      "symbol": "TUSD",
      "price": "0.004209231256068745"
    },
    {
      "symbol": "LPT",
      "price": "0.01367893869282949"
    },
    {
      "symbol": "ENJ",
      "price": "0.00074753598647237"
    },
    {
      "symbol": "POWR",
      "price": "0.000421"
    },
    {
      "symbol": "REQ",
      "price": "0.000073354639301016"
    },
    {
      "symbol": "DNT",
      "price": "0.000025122993832038"
    },
    {
      "symbol": "MATIC",
      "price": "0.000100578952456613"
    },
    {
      "symbol": "LRC",
      "price": "0.00039352319384783"
    },
    {
      "symbol": "RDN",
      "price": "0.001012161449061757"
    },
    {
      "symbol": "USDT",
      "price": "0.004286"
    },
    {
      "symbol": "GST2",
      "price": "0.03"
    },
    {
      "symbol": "COMP",
      "price": "1.188481296128390702"
    }
  ]
}

Testing Instructions

Checklist

  • Update documentation as needed. Website Documentation PR:
  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.

@dekz dekz requested a review from johnrjj June 21, 2020 00:31
@dekz
Copy link
Member Author

dekz commented Jun 21, 2020

deploy staging

@dekz
Copy link
Member Author

dekz commented Jun 21, 2020

deploy production

@dekz dekz merged commit 864ea92 into master Jun 21, 2020
@dekz dekz deleted the fix/filter-test-tokens branch June 21, 2020 00:45
github-actions bot pushed a commit that referenced this pull request Jun 22, 2020
# [1.9.0](v1.8.0...v1.9.0) (2020-06-22)

### Bug Fixes

* asset swapper monorepo f14b6f2ba ([#257](#257)) ([a03630a](a03630a))
* Disable quote validation temporarily ([#259](#259)) ([6064f3e](6064f3e))
* filter tokens in prices which do not exist on the network ([#265](#265)) ([864ea92](864ea92))
* Fix parameters sent off to RFQT providers to be unescaped ([#264](#264)) ([939cae1](939cae1))
* validation gas limit ([#260](#260)) ([f50425c](f50425c)), closes [#259](#259)
* WETH wrap gas estimate ([#256](#256)) ([f07b4a8](f07b4a8))

### Features

* add signer liveness status gauge ([#255](#255)) ([11446e7](11446e7))
* support renamed parameters in RFQT maker endpoint ([#258](#258)) ([d83bbb1](d83bbb1))
@github-actions
Copy link

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant