From 942e43abc019e7eb8a3dd31f0b0195a9d78017e3 Mon Sep 17 00:00:00 2001 From: Pioua <136521243+dzizazda@users.noreply.github.com> Date: Sun, 10 Dec 2023 01:49:04 +0000 Subject: [PATCH 1/5] typo fix --- evm/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/evm/README.md b/evm/README.md index b15bd776aa..5293f8ba8a 100644 --- a/evm/README.md +++ b/evm/README.md @@ -18,7 +18,7 @@ Audits for the ZK-EVM will begin on November 27th, 2023. See the [Audit RC1 Mile ## Documentation / Specification -The current specification is located in the [/spec](/spec) directory, with the most currently up-to-date PDF [availabe here](https://github.com/0xPolygonZero/plonky2/blob/main/evm/spec/zkevm.pdf). Further documentation will be made over the coming months. +The current specification is located in the [/spec](/spec) directory, with the most currently up-to-date PDF [available here](https://github.com/0xPolygonZero/plonky2/blob/main/evm/spec/zkevm.pdf). Further documentation will be made over the coming months. --- Copyright (C) 2023 PT Services DMCC From 724437d0537cfb3531b5608f41ac06dd7e33750c Mon Sep 17 00:00:00 2001 From: Pioua <136521243+dzizazda@users.noreply.github.com> Date: Sun, 10 Dec 2023 01:53:57 +0000 Subject: [PATCH 2/5] typo fix --- evm/spec/cpulogic.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/evm/spec/cpulogic.tex b/evm/spec/cpulogic.tex index ff38096645..0f62b9fe67 100644 --- a/evm/spec/cpulogic.tex +++ b/evm/spec/cpulogic.tex @@ -98,7 +98,7 @@ \subsection{Privileged instructions} empty length is not valid, nor is a length greater than 32 (as a U256 consists in at most 32 bytes). Missing these conditions will result in an unverifiable proof. \item[0xF9.] \texttt{EXIT\_KERNEL}. Pops 1 element from the stack. This instruction is used at the end of a syscall, before proceeding to the rest of the execution logic. - The popped element, \textit{kexit\_info}, contains several informations like the current program counter, current gas used, and if we are in kernel (i.e. privileged) mode. + The popped element, \textit{kexit\_info}, contains several information like the current program counter, current gas used, and if we are in kernel (i.e. privileged) mode. \item[0xFB.] \texttt{MLOAD\_GENERAL}. Pops 3 elements (successively the context, segment, and offset portions of a Memory address), and pushes the value stored at this memory address onto the stack. It can read any memory location, general (similarly to MLOAD (0x51) instruction) or privileged. From 00ed16fc8e174edfe016fa589e2b900c11c08193 Mon Sep 17 00:00:00 2001 From: Pioua <136521243+dzizazda@users.noreply.github.com> Date: Sun, 10 Dec 2023 01:54:20 +0000 Subject: [PATCH 3/5] minor typo fix --- evm/spec/mpts.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/evm/spec/mpts.tex b/evm/spec/mpts.tex index bb0547cd80..91da59ce5c 100644 --- a/evm/spec/mpts.tex +++ b/evm/spec/mpts.tex @@ -59,7 +59,7 @@ \subsection{Prover input format} \item A digest node is encoded as $(\texttt{MPT\_NODE\_HASH}, d)$, where $d$ is a Keccak256 digest. \end{enumerate} Nodes are thus given in depth-first order, enabling natural recursive methods for encoding and decoding this format. -The payload of state and receipt tries is given in the natural sequential way. The transaction an receipt payloads contain variable size data, thus the input is slightly different. The prover input for for the transactions is the transaction RLP encoding preceeded by its lenght. For the receipts is in the natural sequential way, except that topics and data are preceeded by their lengths, respectively. +The payload of state and receipt tries is given in the natural sequential way. The transaction an receipt payloads contain variable size data, thus the input is slightly different. The prover input for for the transactions is the transaction RLP encoding preceeded by its length. For the receipts is in the natural sequential way, except that topics and data are preceeded by their lengths, respectively. \subsection{Encoding and Hashing} From 4e4e61c2a88e37856ed317ea964ef976dd36f152 Mon Sep 17 00:00:00 2001 From: Pioua <136521243+dzizazda@users.noreply.github.com> Date: Tue, 12 Dec 2023 05:16:12 +0000 Subject: [PATCH 4/5] typo fix --- evm/spec/cpulogic.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/evm/spec/cpulogic.tex b/evm/spec/cpulogic.tex index 0f62b9fe67..152cde1a2d 100644 --- a/evm/spec/cpulogic.tex +++ b/evm/spec/cpulogic.tex @@ -98,7 +98,7 @@ \subsection{Privileged instructions} empty length is not valid, nor is a length greater than 32 (as a U256 consists in at most 32 bytes). Missing these conditions will result in an unverifiable proof. \item[0xF9.] \texttt{EXIT\_KERNEL}. Pops 1 element from the stack. This instruction is used at the end of a syscall, before proceeding to the rest of the execution logic. - The popped element, \textit{kexit\_info}, contains several information like the current program counter, current gas used, and if we are in kernel (i.e. privileged) mode. + The popped element, \textit{kexit\_info}, contains several information like the current program counter, the current amount of gas used, and whether we are in kernel (i.e. privileged) mode or not. \item[0xFB.] \texttt{MLOAD\_GENERAL}. Pops 3 elements (successively the context, segment, and offset portions of a Memory address), and pushes the value stored at this memory address onto the stack. It can read any memory location, general (similarly to MLOAD (0x51) instruction) or privileged. From 837434cf8134be9f49cc4b6158719f4e849d16a2 Mon Sep 17 00:00:00 2001 From: Ben Date: Tue, 12 Dec 2023 07:03:29 +0000 Subject: [PATCH 5/5] Fix a minor typo in evm/spec/cpulogic.tex --- evm/spec/cpulogic.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/evm/spec/cpulogic.tex b/evm/spec/cpulogic.tex index 152cde1a2d..df866daf1a 100644 --- a/evm/spec/cpulogic.tex +++ b/evm/spec/cpulogic.tex @@ -98,7 +98,7 @@ \subsection{Privileged instructions} empty length is not valid, nor is a length greater than 32 (as a U256 consists in at most 32 bytes). Missing these conditions will result in an unverifiable proof. \item[0xF9.] \texttt{EXIT\_KERNEL}. Pops 1 element from the stack. This instruction is used at the end of a syscall, before proceeding to the rest of the execution logic. - The popped element, \textit{kexit\_info}, contains several information like the current program counter, the current amount of gas used, and whether we are in kernel (i.e. privileged) mode or not. + The popped element, \textit{kexit\_info}, contains several pieces of information like the current program counter, the current amount of gas used, and whether we are in kernel (i.e. privileged) mode or not. \item[0xFB.] \texttt{MLOAD\_GENERAL}. Pops 3 elements (successively the context, segment, and offset portions of a Memory address), and pushes the value stored at this memory address onto the stack. It can read any memory location, general (similarly to MLOAD (0x51) instruction) or privileged.