-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use core Range for interval checks #535
Comments
Can I work on this issue if it's not a priority right now? |
Yes, that would be awesome! I'll assign it to you. |
Hi @amankrx , how is the progress going with this issue? If you need help/clarification with something, don't hesitate to ask. Thanks for the contribution! |
Hey, There were a lot of places where we had to implement the Range queries. So, it took a little bit of time to check all of that. Also, my exams were going on in the meantime, so I asked about the priority for this issue initially. Nevertheless, I will put an initial draft asap. |
@amankrx thank you! And take your time. One thing I want to note: the scope of this should be limited to the assembler - no need to go beyond that. |
Closed by #595 |
We should use Range for interval checks, given their nature to reduce chances of error for repeated checks, and will cause no overhead due to their efficient implementation
They are also idiomatic to Rust and expected in many libraries and trait implementations
Originally posted by @vlopes11 in #526 (comment)
The text was updated successfully, but these errors were encountered: