Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use core Range for interval checks #535

Closed
Tracked by #547
vlopes11 opened this issue Nov 21, 2022 · 6 comments
Closed
Tracked by #547

Use core Range for interval checks #535

vlopes11 opened this issue Nov 21, 2022 · 6 comments
Assignees
Labels
assembly Related to Miden assembly good first issue Good for newcomers

Comments

@vlopes11
Copy link
Contributor

We should use Range for interval checks, given their nature to reduce chances of error for repeated checks, and will cause no overhead due to their efficient implementation

They are also idiomatic to Rust and expected in many libraries and trait implementations

Originally posted by @vlopes11 in #526 (comment)

@vlopes11 vlopes11 added the good first issue Good for newcomers label Nov 21, 2022
@bobbinth bobbinth added assembly Related to Miden assembly v0.4 labels Nov 21, 2022
@amankrx
Copy link
Contributor

amankrx commented Nov 22, 2022

Can I work on this issue if it's not a priority right now?

@bobbinth
Copy link
Contributor

Yes, that would be awesome! I'll assign it to you.

@vlopes11
Copy link
Contributor Author

vlopes11 commented Dec 2, 2022

Hi @amankrx , how is the progress going with this issue? If you need help/clarification with something, don't hesitate to ask. Thanks for the contribution!

@amankrx
Copy link
Contributor

amankrx commented Dec 2, 2022

Hi @amankrx, how is the progress going with this issue? If you need help/clarification with something, don't hesitate to ask. Thanks for the contribution!

Hey, There were a lot of places where we had to implement the Range queries. So, it took a little bit of time to check all of that. Also, my exams were going on in the meantime, so I asked about the priority for this issue initially. Nevertheless, I will put an initial draft asap.

@bobbinth
Copy link
Contributor

bobbinth commented Dec 2, 2022

@amankrx thank you! And take your time. One thing I want to note: the scope of this should be limited to the assembler - no need to go beyond that.

@vlopes11
Copy link
Contributor Author

vlopes11 commented Feb 9, 2023

Closed by #595

@vlopes11 vlopes11 closed this as completed Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assembly Related to Miden assembly good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants