Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store endpoint: get_tx_inputs #54

Closed
Dominik1999 opened this issue Oct 30, 2023 · 5 comments
Closed

Store endpoint: get_tx_inputs #54

Dominik1999 opened this issue Oct 30, 2023 · 5 comments
Assignees
Labels
store Related to the store component
Milestone

Comments

@Dominik1999
Copy link
Contributor

@plafer to create

@plafer plafer changed the title get_tx_inputs Store endpoint: get_tx_inputs Oct 30, 2023
@plafer
Copy link
Contributor

plafer commented Oct 30, 2023

Implement a gRPC endpoint which corresponds to this method. That is, inputs a ProvenTransaction, and outputs the protobuf version of TxInputs.

@bobbinth
Copy link
Contributor

To specify the endpoint in terms of request/response - here is what I'm thinking:

Request {
    accounts: [list of account IDs involved in the transaction],
    nullifiers: [list of nullifiers created in the course of the transaction],
}

Response {
    accounts: [list of account state hashes for each of the specified IDs],
    nullifiers: [a list of boolean values for each nullifier indicating whether the nullifier has been consumed],
}

@bobbinth
Copy link
Contributor

One potential modification to the above: maybe instead of boolean values for the nullifiers we should return a list of block heights at which the nullifiers were inserted into the chain (or 0 for nullifiers which haven't been inserted). This will help with better error messaging as we'll be able to say that a given nullifier was already consumed at such and such block.

@bobbinth bobbinth added the store Related to the store component label Nov 1, 2023
@bobbinth bobbinth added this to the v0.1 milestone Nov 1, 2023
@hackaugusto
Copy link
Contributor

@bobbinth I believe this can be closed, right?

@hackaugusto
Copy link
Contributor

implemented by #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
store Related to the store component
Projects
No open projects
Development

No branches or pull requests

4 participants