Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Syncer] Save stage_batches progress in intervals #641

Closed
V-Staykov opened this issue Jun 18, 2024 · 0 comments · Fixed by #663
Closed

[Syncer] Save stage_batches progress in intervals #641

V-Staykov opened this issue Jun 18, 2024 · 0 comments · Fixed by #663
Assignees

Comments

@V-Staykov
Copy link
Collaborator

V-Staykov commented Jun 18, 2024

Rationale

Why should this feature exist?

Currently stage batches doesn't save the downloaded batches until the end of the stage. If it is interrupted - the DB transaction is reverted. In some cases this could lose a lot of quality data that will have to be downloaded again.

What are the use-cases?

Some networks like zkEvm Mainnet and XLayer have a lot of blocks and even stage_batches takes some time to run. It won't take much to make it save it's progress each 2m blocks or so.

Implementation

Do you have ideas regarding the implementation of this feature?

Make it commit the tx and create a new once a saved blocks counter reaches 2m or so.

@V-Staykov V-Staykov self-assigned this Jun 18, 2024
@V-Staykov V-Staykov linked a pull request Jun 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant