Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Can not open any url in Notepads #434

Closed
caizefeng opened this issue Apr 10, 2020 · 5 comments
Closed

[Bug] Can not open any url in Notepads #434

caizefeng opened this issue Apr 10, 2020 · 5 comments
Assignees
Labels
bug Something isn't working Fixed

Comments

@caizefeng
Copy link

caizefeng commented Apr 10, 2020

Describe the bug
two problem actually, but maybe due to the same reason.

  1. Only searching via "google" is available, neither "Bing" nor "Duck Duck go" works well (the browser cant pop up). (basicly click the button and nothing happens)
  2. Almost every url link on markdown preview ( and on "settings" sidebar ) cant be opened, the browser can't pop as well. (basicly click the url and nothing happens)

Desktop (please complete the following information):

  • OS: [e.g. Windows 10 1909 18363.720]
  • Version [e.g. v1.2.1.0]

Additional context

  1. I was thinking it's my network setting at the first place, but changing to another default browser (chrome -> edge) didn't help.
  2. I once used Fiddler to allow UMP app accessible to local ports before, but the situation did not change after i disabled this loopback exemption thing,
  3. I was thinking it's because of using proxy (actually browser not popping indicates that probably not the case ), closing proxy did not help.
@0x7c13
Copy link
Owner

0x7c13 commented Apr 10, 2020

It might due to this issue: #377

I send out a PR to fix the problem in Windows Community Toolkit and it has been merged: CommunityToolkit/WindowsCommunityToolkit#3180

@caizefeng
Copy link
Author

thanks, so it means the bug can not be fixed till new Windows Community Toolkit is released ?

@0x7c13
Copy link
Owner

0x7c13 commented Apr 11, 2020

thanks, so it means the bug can not be fixed till new Windows Community Toolkit is released ?

Actually, I am waiting for this PR to check-in: CommunityToolkit/WindowsCommunityToolkit#3206
This PR addresses some threading issues with the toolkit so it can help resolve issues with the Notepads Xbox game bar widget implementation. I will use the nightly build after this PR which will also have my fix for the MarkdownTextBlock. If everything works fine I will just use it for the next Notepads release.

@0x7c13 0x7c13 added the bug Something isn't working label Apr 11, 2020
@0x7c13 0x7c13 self-assigned this Apr 11, 2020
@0x7c13
Copy link
Owner

0x7c13 commented Apr 13, 2020

This has been fixed in master and will be part of next release.

@0x7c13 0x7c13 added the Fixed label Apr 13, 2020
@0x7c13
Copy link
Owner

0x7c13 commented Apr 14, 2020

Closing this since v1.2.2.0 is out.

@0x7c13 0x7c13 closed this as completed Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fixed
Projects
None yet
Development

No branches or pull requests

2 participants