-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wheels #17
Comments
I guess for macos we need to set MACOSX_DEPLOYMENT_TARGET="10.14" in the env |
I think what's happening here is that, since we ignore The |
The wheel is built with the wrong platform tag, repairing does not change that |
For what I understand, auditwheel relabels the wheel based on the minimum manylinux policy supported by the dependencies. In our case, if there was a way of keeping libarrow in the dependencies, but avoid copying the library, it would create a manylinux_2_17 wheel. I don't know how the macos minimum version work, but I guess it should work the same? If you build something compatible with macos 10.9+, that depends on something compatible macos 10.14+, if the ABI is backwards compatible, you should not need to recompile and the wheel should be relabeled for 10.14. |
On my local build, if I just do
The wheel produced is tagged 10.9 Setting MACOSX_DEPLOYMENT_TARGET removes the linker warnings and produce the expected wheel |
#24 sets MACOSX_DEPLOYMENT_TARGET="10.14" |
I believe the CI built wheels are still wrong, we should have the same dependencies as pyarrow
ATM we have
macos 10.9 / manylinux_2_5
The text was updated successfully, but these errors were encountered: