Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO #10

Closed
7 tasks done
0x0L opened this issue Feb 21, 2023 · 5 comments
Closed
7 tasks done

TODO #10

0x0L opened this issue Feb 21, 2023 · 5 comments

Comments

@0x0L
Copy link
Owner

0x0L commented Feb 21, 2023

  • Run the tests on the CI
  • Setup db on the CI and run tests against it
  • Python package cosmetics, docstrings, types
  • Window build
  • Fix wheels
    * macosx min platform
    * manylinux platform tag on linux without auditwheel
  • make pgeon a proper python package instead of two modules (pgeon and _pgeon)
  • Add a simple C++ cli tool to have a simpler debug workflow
@rdbisme
Copy link
Collaborator

rdbisme commented Feb 21, 2023

  • manylinux platform tag on linux without auditwheel
  • make pgeon a proper python package instead of two modules (pgeon and _pgeon)

Can you elaborate a bit on this two points?

@0x0L
Copy link
Owner Author

0x0L commented Feb 21, 2023

  1. ATM the linux build is tagged "linux_x86_64" which would prevent upload to pypi if I understand that correctly. I guess we just need to manually override the platform in setup.py for linux

  2. pgeon is not a package per se (no __init__.py) it's just two modules pgeon.py and _pgeon.cpython.so. Probably just a matter of renaming pgeon.py to __init__.py and adding the proper relevant info in setup.py

@rdbisme
Copy link
Collaborator

rdbisme commented Feb 21, 2023

About ignoring libraries in auditwheel: pypa/auditwheel#76

@0x0L
Copy link
Owner Author

0x0L commented Feb 21, 2023

pypa/auditwheel#76 (comment)
Not linking at all seems even better

@rdbisme
Copy link
Collaborator

rdbisme commented Feb 21, 2023

#14

This creates the manylinux without integrating pyarrow into it. Looks cleaner to me then not linking... We get all the niceties about reading the .so dependencies and so on.

@0x0L 0x0L closed this as completed Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants