Non-embedded icon

[myself600]

The GAME variable is used to embed the icon into the executable, which isn't optimal since the engine is shared between games. Would it be possible to change this so that it picks up the icon from the game folder just like with Ren'Py?

[drojf]

I'm not sure if this answers your question, but you can change the icon by changing the default.icns, default.ico, and default.png files in the src/resources folder

---

If you're using our github actions script to build, it still has some Umineko specific stuff in it (my fault) like having copies of the exe for question and answer, and I was supposed to fix it as described in issue #11, but I just hadn't got around to it.

If you're going to be using it however, I'd definitely want to fix it for you.

[myself600]

I'm building distribution specific packages from source and there's a separate package for the engine and the game, so the icon is stored outside ponscripter

[TellowKrinkle]

I assume that means the exe itself would have the wrong icon, but the app would change the one displayed in the taskbar after launching?

Would you want to do that with a script command?

[TellowKrinkle]

Actually, maybe it would be better as a command line option? Then you don't have to modify the game script to set it. I assume you're launching programmatically, since otherwise the user would be able to see the (wrong) exe icon.

[TellowKrinkle]

Hmm it looks like it's already set up to load an icon named icon.png, though that looks like it's from the cwd instead of the game root dir or something like that. Does that work for you?

ponscripter-fork/src/PonscripterLabel.cpp

Line 518 in a39f9b6

SDL_Surface* icon = IMG_Load("icon.png");

[myself600]

Does that work for you?

Yes, thanks!