Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'BGM Currently Playing' feature #90

Closed
3 tasks
drojf opened this issue Oct 11, 2022 · 5 comments
Closed
3 tasks

Add 'BGM Currently Playing' feature #90

drojf opened this issue Oct 11, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@drojf
Copy link
Contributor

drojf commented Oct 11, 2022

Sometimes we get asked what a certain BGM is in the Discord.

We could implement a feature similar to what the original game has, which displays the name of the BGM being played. Currently, the game/mod has no mapping of filename -> actual song name, so we'd need to add that in somehow (probably a .json file inside each BGM folder). There's also the complication of there being multiple BGM folders (such as the OGBGM folder)

I think the original game has an (option?) which shows the name of the currently playing BGM for a few seconds when it starts playing.

@andOlga suggested we instead display it on the pause menu (right click menu). I think this is easier to implement, and also allows you to check what BGM is playing at any time without adding additional shortcuts or buttons. I could pretty easily add a button which shows the file on disk too.

It's probably a good idea to display both the filename and the song name, since you may want to just find which file it is on disk (and also for our mod's debugging purposes, to check the correct BGM is playing at any given time)

TODO:

  • Improve appearance
  • fill out bgm databse (for both question and answer, if the same database can't be used for both)
  • add an indicator of where the BGM file comes from (default BGM, GIN's BGM, or any other bgm source)
@drojf drojf added the enhancement New feature or request label Oct 11, 2022
@drojf
Copy link
Contributor Author

drojf commented Oct 13, 2022

I've basically got this working. The main things to do are:

  • improve appearance (optional)
  • create filename -> BGM name database for the BGM and OGBGM folders
    • This is confusing to do due to the april update changes. However it looks like there is a good list on the Higurashi wiki of the BGM, which is probably the best place to start

Relevant to the OGBGM Folder:

Relevant to the BGM folder:

Relevant to both:


So far I have the following for the Answer arcs. Probably easier to make a shared google sheets, fill it in there, then generate the JSON File from it.

Meakashi BGM

{
    "bgmList":
    {
        "4" : {
            "name": "Digital Network",
            "nameJP": "Digital Network"
        },
        "mion" : {
            "name": "Spring Step (Mion)",
            "nameJP": "Spring Step (Mion)"
        }
    }
}

Meakashi OGBGM

{
    "bgmList":
    {
        "4" : {
            "name": "Digital Network",
            "nameJP": "Digital Network"
        },
        "mion" : {
            "name": "Spring Step (Mion)",
            "nameJP": "Spring Step (Mion)"
        }
    }
}

@drojf
Copy link
Contributor Author

drojf commented Oct 14, 2022

Starting putting together all the information I can find into this document: https://docs.google.com/spreadsheets/d/1CzZ6IBOPmDozdatWM2rol1DR2xjIaySSKY5XQV4yhdI/edit#gid=1854485371

@drojf
Copy link
Contributor Author

drojf commented Oct 14, 2022

This "Mario3573" has uploaded every BGM that appears in Higurashi in chronological order, with the BGM name (not filename): https://www.youtube.com/playlist?list=PL0YDec1hvdtU_2JXMxO-sByllanTyTrfb

Ordered by appearance in the VN, includes both the original versions and the Radiata Alice versions from the 07th-Mod Patch.

Also doesn't have those annoying anime screenshot thumbnail spoilers.

Rei added, all its new BGM comes from Daybreak. See you in 2024 for Hou.

For now, I'll automatically match our mod's BGM against this playlist (using audio similarity matching) to get all the BGM names (without manually checking any of them), as this seems like a good reference. This is a lot easier than what I was trying to do earlier. If there are any missing, those can be fixed manually.

I think it should be good enough that if there are any errors, we can correct them later.

@drojf
Copy link
Contributor Author

drojf commented Oct 15, 2022

Another source for song names from the (console game?): https://gall.dcinside.com/mgallery/board/view/?id=higurashi&no=58473 - from the screenshot, they extracted the bgm names from the game files

Besides the textual list, there is a download of every bgm, which has been renamed as hmXX_XX - so I can add it to my BGM matching script easily.

@drojf
Copy link
Contributor Author

drojf commented Nov 27, 2022

This feature has been added to all chapters (except console which hasn't had its DLL updated yet), see:

@drojf drojf closed this as completed Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant