Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Database fetch_results method #219

Closed
kalombos opened this issue May 3, 2024 · 1 comment
Closed

Refactor Database fetch_results method #219

kalombos opened this issue May 3, 2024 · 1 comment

Comments

@kalombos
Copy link
Collaborator

kalombos commented May 3, 2024

В AsyncDatabase не должно быть метода fetch_results, логика должна быть перенесена в соответствующие Query-классы: ModelCompoundSelectQuery, RawQuery. Кстати, нужно проверить, есть ли на них тесты, насколько помню тестов на ModelCompoundSelectQuery не было.

There should not be a fetch_results method in AsyncDatabase. The logic should be transferred to the corresponding Query classes: ModelCompoundSelectQuery, RawQuery. By the way, you need to check if there are tests for them; as far as I remember, there were no tests for ModelCompoundSelectQuery.

#237 #236

@rudyryk
Copy link
Member

rudyryk commented May 4, 2024

Manager extracted to compatibility module in PR #232

Seems like AsyncDatabase.fetch_results might be safely removed, it actually never gets called in tests, check #233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants