Add HTML id and class attributes to MenuLinks #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hallo Chris, and thanks for this, it looks very nice 👍 ! |
|
No worries, have a great holiday! ☀️ |
|
Actually, after a closer look on your code, have i decided to merge anyways! It all looks great, and i can always change it later if there should be something... :) Again thank you for the contribution ! |
jokklan
pushed a commit
that referenced
this pull request
Jan 24, 2013
Add HTML id and class attributes to MenuLinks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Johan,
This is the change | mentioned in my email - add an id and class attribute to any menulink.
I've added a very simplistic spec to prove that it's working - and I've tested it in my own project which I need this functionality for.
Hope you don't mind, but I've tweaked the admin CSS, and added a couple of lines to the README as well. I've also removed some trailing whitespace, although this isn't intentional - my editor does it for me, but I thought it was nice to have tidier code. Feel free to just cherry-pick the functional commits if you're not interested in any of these extras!
If I've missed anything, or you're not happy with the changeset, just let me know.
-Chris