Generate inbound/outbound for HTTP/2 #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 28, 2020 16:46
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
lobkovilya
approved these changes
Aug 28, 2020
| @@ -53,8 +53,10 @@ func (g InboundProxyGenerator) Generate(ctx xds_context.Context, proxy *model.Pr | |||
| filterChainBuilder := func() *envoy_listeners.FilterChainBuilder { | |||
| filterChainBuilder := envoy_listeners.NewFilterChainBuilder() | |||
| switch protocol { | |||
| // configuration for HTTP case | |||
| case mesh_core.ProtocolHTTP: | |||
There was a problem hiding this comment.
I'd still prefer :)
Suggested change
| case mesh_core.ProtocolHTTP: | |
| case mesh_core.ProtocolHTTP, mesh_core.ProtocolHTTP2: |
| fallthrough | ||
| case mesh_core.ProtocolHTTP2: | ||
| fallthrough | ||
| case mesh_core.ProtocolGRPC: |
There was a problem hiding this comment.
and
Suggested change
| case mesh_core.ProtocolGRPC: | |
| case mesh_core.ProtocolHTTP, mesh_core.ProtocolHTTP2, mesh_core.ProtocolGRPC: |
| case mesh_core.ProtocolHTTP: | ||
| fallthrough | ||
| case mesh_core.ProtocolHTTP2: |
There was a problem hiding this comment.
Suggested change
| case mesh_core.ProtocolHTTP2: | |
| case mesh_core.ProtocolHTTP, mesh_core.ProtocolHTTP2: |
|
@nickolaev #991 is also fixed by this PR i think. |
|
Double tested with HTTP/2 and gRPC server client |
jakubdyszkiewicz
approved these changes
Aug 31, 2020
added 2 commits
August 31, 2020 17:21
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
nickolaev
pushed a commit
that referenced
this pull request
Oct 1, 2020
* fix(kuma-cp) generate RDS for HTTP, HTTP/2 and gRPC * fix(kuma-cp) generate inbound also for HTTP/2 * test(kuma-cp) fix xds/generator test Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As noted in #997, we have gaps in handling HTTP/2 and gRPC when generating the XDS configuration Snapshots. This PR proposes a fix for this on all the relevant places, plus adds/fixes the relevant tests.
Issues resolved
Fix #997 #991
Documentation